Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes both Lesser Drone and Facehugger respawn times to 1 Minute #5691

Closed

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Feb 9, 2024

About the pull request

Explain why it's good for the game

Total changes:

pt 1: Facehugger respawn time reduced from 3 minutes to 1 minute
Pt 2: Lesser drone respawn time upped from 30 seconds to 1 minute


Right now people spam out lessers because 30 seconds respawn time and people who would go hugger don’t want to wait out the 3 minute time on something that can die to a stray bullet so they just go lesser instead.

This change would make dedicated lesser players less annoying from near instant respawning -> tunnel to frontline and while making dying to a stray bullet from 3 screens away as hugger way less frustrating.

Testing Photographs and Procedure

tested and functional :3

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑

balance: Facehugger respawn time reduced from 3 minutes to 1 minute
balance: Lesser drone respawn time upped from 30 seconds to 1 minute
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 9, 2024
@GrrrKitten GrrrKitten marked this pull request as draft February 9, 2024 23:31
@GrrrKitten
Copy link
Contributor Author

realized when testing there is a lil more I gotta do whoopsies

@GrrrKitten GrrrKitten marked this pull request as ready for review February 10, 2024 00:18
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 17, 2024
@@ -856,7 +856,7 @@
return FALSE
if(world.time - user.timeofdeath < JOIN_AS_FACEHUGGER_DELAY)
var/time_left = round((user.timeofdeath + JOIN_AS_FACEHUGGER_DELAY - world.time) / 10)
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a facehugger until 3 minutes have passed ([time_left] seconds remaining)."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the timer not be done as DisplayTimeText(JOIN_AS_FACEHUGGER_DELAY)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the lesser drone timer

Comment on lines +722 to +723
#define JOIN_AS_FACEHUGGER_DELAY (1 MINUTES)
#define JOIN_AS_LESSER_DRONE_DELAY (1 MINUTES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with an increased lesser drone delay.

I do not think we need to make face huggers spawn faster when they already can spawn instantly if they successfully hug.

@@ -911,7 +911,7 @@

if(world.time - user.timeofdeath < JOIN_AS_LESSER_DRONE_DELAY)
var/time_left = round((user.timeofdeath + JOIN_AS_LESSER_DRONE_DELAY - world.time) / 10)
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a lesser drone until 30 seconds have passed ([time_left] seconds remaining)."))
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a lesser drone until 1 minute has passed ([time_left] seconds remaining)."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using DisplayTimeText as Beagle had suggested.

@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 19, 2024
@Drulikar Drulikar marked this pull request as draft February 19, 2024 04:38
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 27, 2024
@GrrrKitten GrrrKitten closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants